New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_csv2() locale issues #443

Merged
merged 3 commits into from Jan 23, 2017

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Jun 25, 2016

A message is provided if the locale is updated automatically by read_csv2(); if the caller passes an explict locale, it is not updated.

@hadley

This comment has been minimized.

Member

hadley commented Jun 25, 2016

I think it always needs to update - but I like the message

@krlmlr krlmlr force-pushed the krlmlr:f-csv2-message branch 2 times, most recently from 5be8ca1 to 8a5dc18 Jun 25, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jun 25, 2016

Now gives message only, the message shows alternatives.

@hadley hadley added this to the 0.3.0 milestone Jul 14, 2016

@hadley

This comment has been minimized.

Member

hadley commented Dec 28, 2016

LGTM

@krlmlr krlmlr force-pushed the krlmlr:f-csv2-message branch from f965fb1 to 06a46a9 Dec 28, 2016

@krlmlr krlmlr force-pushed the krlmlr:f-csv2-message branch from 06a46a9 to 727604e Dec 28, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 28, 2016

Thanks, rebased. I can't merge this myself.

@jimhester jimhester merged commit 727604e into tidyverse:master Jan 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jimhester

This comment has been minimized.

Member

jimhester commented Jan 23, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment