Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_table using any whitespace as a delimiter #608

Merged
merged 2 commits into from Feb 21, 2017
Merged

read_table using any whitespace as a delimiter #608

merged 2 commits into from Feb 21, 2017

Conversation

@jimhester
Copy link
Member

@jimhester jimhester commented Feb 9, 2017

Fixes #607

This implementation replaces the current implementation of read_table(). Not sure if we want to do that or preserve the old behavior as read_table() or another function.

@hadley
Copy link
Member

@hadley hadley commented Feb 9, 2017

I think we need to preserve existing read_table(); I'd rather make this read_delim(delim = "") or some other special sentinel

@jimhester
Copy link
Member Author

@jimhester jimhester commented Feb 9, 2017

could we call this read_ws_delim() or read_table_ws() or some variant of that? A sentinel value that uses a completely different tokenizer seems like surprising behavior to me.

@hadley
Copy link
Member

@hadley hadley commented Feb 9, 2017

Oh true, the behaviour wrt quotes etc is totally different. Maybe to echo read_csv maybe just read_table2()?

jimhester added a commit that referenced this pull request Feb 9, 2017
This is a more exact replacement for `utils::read.table()`

Fixes #608
@jimhester jimhester requested a review from hadley Feb 20, 2017
@hadley
hadley approved these changes Feb 20, 2017
#' arbitrary amounts of whitespace, it first finds empty columns and then
#' parses like a fixed width file. `spec_table()` returns the column
#' specification rather than a data frame.
#' `read_table()` and `read_table2()` are designed to read the type of textual

This comment has been minimized.

@hadley

hadley Feb 20, 2017
Member

You might want to add an explicit @description here


#' @export
#' @rdname Tokenizers
#' @param begin,end Begin and end offsets for each file. These are C++

This comment has been minimized.

@hadley

hadley Feb 20, 2017
Member

Included by mistake?

This comment has been minimized.

@jimhester

jimhester Feb 20, 2017
Author Member

Yep thanks

jimhester added 2 commits Feb 9, 2017
This is a more exact replacement for `utils::read.table()`

Fixes #608
@jimhester jimhester merged commit 33f3f38 into master Feb 21, 2017
0 of 4 checks passed
0 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants