Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_table using any whitespace as a delimiter #608

Merged
merged 2 commits into from Feb 21, 2017
Merged

read_table using any whitespace as a delimiter #608

merged 2 commits into from Feb 21, 2017

Conversation

jimhester
Copy link
Collaborator

Fixes #607

This implementation replaces the current implementation of read_table(). Not sure if we want to do that or preserve the old behavior as read_table() or another function.

@hadley
Copy link
Member

hadley commented Feb 9, 2017

I think we need to preserve existing read_table(); I'd rather make this read_delim(delim = "") or some other special sentinel

@jimhester
Copy link
Collaborator Author

could we call this read_ws_delim() or read_table_ws() or some variant of that? A sentinel value that uses a completely different tokenizer seems like surprising behavior to me.

@hadley
Copy link
Member

hadley commented Feb 9, 2017

Oh true, the behaviour wrt quotes etc is totally different. Maybe to echo read_csv maybe just read_table2()?

jimhester added a commit that referenced this pull request Feb 9, 2017
This is a more exact replacement for `utils::read.table()`

Fixes #608
R/read_table.R Outdated
#' arbitrary amounts of whitespace, it first finds empty columns and then
#' parses like a fixed width file. `spec_table()` returns the column
#' specification rather than a data frame.
#' `read_table()` and `read_table2()` are designed to read the type of textual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add an explicit @description here

R/tokenizer.R Outdated

#' @export
#' @rdname Tokenizers
#' @param begin,end Begin and end offsets for each file. These are C++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included by mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants