change message behavior of read_table#630
Merged
jimhester merged 3 commits intotidyverse:masterfrom Mar 6, 2017
Merged
Conversation
When using `read_table` I was surprised to get a print out of the `spec` even after specifying the `col_type` argument. This is different than `read_csv` and most of the other functions in `readr`. Currently the behavior of `read_table` is to print the spec whenever `progress = TRUE`. This changes the behavior to be similar to that of the other functions in **readr**: print if `col_types` is `NULL`.
Collaborator
|
Looks good, please add a note to NEWS.md with the change and we can merge it. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
read_tableI was surprised to get a print out of thespeceven after specifying thecol_typeargument. This is different thanread_csvand most of the other functions inreadr.Currently the behavior of
read_tableis to print the spec wheneverprogress = TRUE. This changes the behavior to be similar to that of the other functions in readr: print ifcol_typesisNULL.