Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change message behavior of read_table #630

Merged
merged 3 commits into from Mar 6, 2017
Merged

Conversation

@jrnold
Copy link
Contributor

@jrnold jrnold commented Mar 3, 2017

When using read_table I was surprised to get a print out of the spec even after specifying the col_type argument. This is different than read_csv and most of the other functions in readr.

Currently the behavior of read_table is to print the spec whenever progress = TRUE. This changes the behavior to be similar to that of the other functions in readr: print if col_types is NULL.

When using `read_table` I was surprised to get a print out of the `spec` even after specifying the `col_type` argument. This is different than `read_csv` and most of the other functions in `readr`.

Currently the behavior of `read_table` is to print the spec whenever `progress = TRUE`. This changes the behavior to be similar to that of the other functions in **readr**: print if `col_types` is `NULL`.
@jimhester
Copy link
Member

@jimhester jimhester commented Mar 3, 2017

Looks good, please add a note to NEWS.md with the change and we can merge it.

@jimhester
Copy link
Member

@jimhester jimhester commented Mar 6, 2017

Thanks!

@jimhester jimhester merged commit fb27590 into tidyverse:master Mar 6, 2017
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants