Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write_excel_csv2() #753

Merged
merged 6 commits into from Dec 5, 2017
Merged

Add write_excel_csv2() #753

merged 6 commits into from Dec 5, 2017

Conversation

@olgamie
Copy link
Contributor

@olgamie olgamie commented Nov 30, 2017

Create write_excel_csv2() to write csv with semicolon as column separator and comma as decimal separator.

This change is required to allow majority of European users easily write csv to a format that would automatically open a csv in a correct way in Excel.

@jimhester
Copy link
Member

@jimhester jimhester commented Dec 4, 2017

Thanks! Unfortunately we cannot have a dplyr dependency in readr. You can get the same behavior with the following.

numeric_cols <- vapply(x, is.numeric, logical(1))
x[numeric_cols] <- lapply(x[numeric_cols], format, decimal.mark = ",")

Can you also add a note to NEWS.md with this change and mentioning your GitHub username. Thanks!

@jimhester
Copy link
Member

@jimhester jimhester commented Dec 4, 2017

You can push additional changes to the same branch you opened this pull request from, please do not open a new pull request! I can squash the commits when I merge if needed, so don't worry about having additional commits in the pull request.

Thanks!

@olgamie
Copy link
Contributor Author

@olgamie olgamie commented Dec 5, 2017

Thanks for the review. I addressed your comments and added tests on write_excel_csv2.

@jimhester
Copy link
Member

@jimhester jimhester commented Dec 5, 2017

Great, thanks again!

@jimhester jimhester merged commit cf20103 into tidyverse:master Dec 5, 2017
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 79.68%)
Details
@codecov
codecov/project 79.7% (+0.02%) compared to 4d5e81c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants