This pull request allows to provide more than one comment pattern to
It is applied on top of this other PR #677, so merging this will be easier once that PR is reviewed.
This commit allows users to define multiple comments using a character vector. Additionally, comment detection is now handled exclusively by the datasource, before it was splitted between both the datasource and the tokenizer. The `comment` argument in the tokenizer functions is deprecated and will be removed in future versions.
I am reposting my comment from #677 here, again I sincerely apologize but I don't see another option and I don't think it is fair to keep these PRs open when there is no real chance of them being merged.
First, I wanted to thank you for working on this PR and the previous ones. This was not a simple problem and I appreciate the effort you went through to solve it.
I also wanted to apologize for leaving this open for so long, it was certainly not my intent to keep you waiting, but other projects and priorities kept me busy.
We have plans to begin moving away from the legacy parser in readr, in favor of the parsers in vroom or possibly arrow. Because of this I don't think it would be prudent to add this amount of new code to the existing parser.
Developing good software requires relentless focus, which means that we have to say no to many good ideas.
Even though we're closing this issue, we really appreciate your work, and hope you'll continue to contribute in the future.
Hi @jimhester, I totally understand the situation. For me these PR were part of a learning process and it was a wonderful experience to interact with you and the rest of the team. It was worth it, even if in the end it never got merged. I understand the advantages of vroom (using ALTREP, etc) and I'm looking forward to keep contributing in the future as I've done in the past.
Besides, RStudio has my CV in case you ever decide to eventually hire more people and find me worth considering (it's a long shot but hey, it's always worth trying
Thanks for your time and nice words!