New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected column_names processing when incorporated with line skip #178

Closed
boothm opened this Issue May 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@boothm

boothm commented May 26, 2016

I would have expected when skipping lines before starting to read a sheet when column_names is set TRUE, the first line read would be the assumed column_names. If it is always expected that column_names appear in first row, then it would be good feature add have mechanism to specify the starting row for read rather than having it always assumed equal first row when case is that the header is not in first row.

@jennybc

This comment has been minimized.

Member

jennybc commented Jan 31, 2017

The behaviour of skip is about to align much more with expectations, when #240 gets merged.

Please open a new issue with a reprex if you have continuing difficulty after that.

@jennybc jennybc closed this Jan 31, 2017

jennybc added a commit that referenced this issue Jan 31, 2017

Load cells at xlsx worksheet ingest; handle skipping and/or blank row… (
#240)

* Load cells at xlsx worksheet ingest; handle skipping and/or blank rows; fixes #224

* Actually these *should* be the same

* Make skipping tests more challenging (blank row btwn col names and data, plus another embedded blank row)

* Simplify return of 0x0 tibble for completely empty worksheet

* Mark cells to start reading from at the time of worksheet construction

* Remove vestigial, internal cell printing function

* Be quiet about empty worksheet

* More tests of nothingness

* Inform worksheet about its own name

* Tighten up the NEWs bullet for this PR

* Make some accessor member functions const

* Use skip() to issue note-to-future-self

Expedient place to park a summary of what this entire PR does.

* Improved parsing of sheet geometry for xlsx. (#240, @jennybc).

    - Better handling of leading and embedded blank rows and explicit row skipping. (#224, #194, #178, #156, #101)
    - Worksheets that are completely empty or that contain only column names no longer error, but return a tibble with zero rows. (#222, #144, #65)
    - Location is inferred for cells that do not declare their location (e.g. xlsx written by JMP). (#163, #102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment