New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_xlsx doesn't honour `trim_ws` #514

Closed
hroptatyr opened this Issue Oct 29, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hroptatyr
Copy link

hroptatyr commented Oct 29, 2018

## works, i.e. whitespace is *not* trimmed.
read_excel('.xlsx-file', trim_ws=F)

## doesn't work, whitespace is always trimmed
read_xls('.xls-file', trim_ws=F)

## doesn't work, whitespace is trimmed regardless.
read_xlsx('.xlsx-file', trim_ws=F)

It's obvious that the misbehaviour is either a documentation problem (are read_xls and read_xlsx meant to have a trim_ws parameter?) or a code problem when calling the read_excel_ wrapper (the trim_ws parameter is not passed along at all).

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Oct 29, 2018

You are correct with this:

a code problem when calling the read_excel_ wrapper (the trim_ws parameter is not passed along at all

I've fixed and will push soon, but also need to address something else first ...

@jennybc jennybc added the bug label Oct 29, 2018

@jennybc jennybc closed this in e2b8f70 Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment