Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect uppercase date time formats #165

Merged
merged 4 commits into from Jan 19, 2017

Conversation

@zeehio
Copy link
Contributor

@zeehio zeehio commented Mar 29, 2016

Hi,

The dates-1900.xls once opened and saved using LibreOffice 5 was not readable by readxl (it detected dates as numbers).

This patch allows to detect uppercase date time formats (used at least by libreoffice). A test case is included. Note that the test fails due to different autogenerated col_names in xls and xlsx

EDIT: Excel is able to parse the file so I assumed that readxl should be capable too, otherwise the pull request would have gone to libreoffice.

@MichaelChirico
Copy link

@MichaelChirico MichaelChirico commented Dec 7, 2016

Note that this closes #134.

@zeehio I guess it's best to amend the commit message so the issue closing happens automatically?

@zeehio zeehio force-pushed the zeehio:fix_datetimes_libreoffice branch from 3b7b3a0 to a5dcd8d Dec 7, 2016
@zeehio
Copy link
Contributor Author

@zeehio zeehio commented Dec 7, 2016

I updated the commit message. Please note that readxl has been like this for 8 months, so the chances of this being merged in the next few days are not huge. Hopefully eventually someone will work a bit on the package and will deal with the increasing number of pull requests.

(I am just another random readxl user, there is not much more I can do)

@MichaelChirico
Copy link

@MichaelChirico MichaelChirico commented Dec 7, 2016

I hear you, there are a couple of good PRs that would improve the package a lot but it appears it's been on the shelf for some time

@jennybc
Copy link
Member

@jennybc jennybc commented Dec 8, 2016

@MichaelChirico readxl and these PRs will get handled in early 2017

@hadley
Copy link
Member

@hadley hadley commented Jan 18, 2017

Looks good. Can you please add a bullet to NEWS.md?

@zeehio zeehio force-pushed the zeehio:fix_datetimes_libreoffice branch from a5dcd8d to affa367 Jan 18, 2017
@zeehio
Copy link
Contributor Author

@zeehio zeehio commented Jan 19, 2017

Rebased on master and done

@jennybc jennybc merged commit affa367 into tidyverse:master Jan 19, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeehio zeehio deleted the zeehio:fix_datetimes_libreoffice branch Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants