Detect uppercase date time formats #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The
dates-1900.xls
once opened and saved using LibreOffice 5 was not readable byreadxl
(it detected dates as numbers).This patch allows to detect uppercase date time formats (used at least by libreoffice). A test case is included. Note that the test fails due to different autogenerated col_names in xls and xlsx
EDIT: Excel is able to parse the file so I assumed that readxl should be capable too, otherwise the pull request would have gone to libreoffice.