Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDetect uppercase date time formats #165
Conversation
zeehio
referenced this pull request
Apr 11, 2016
Closed
WIP: Equality of autogenerated colnames (xls vs. xlsx) #98
Dec 7, 2016
This was referenced
This comment has been minimized.
This comment has been minimized.
MichaelChirico
commented
Dec 7, 2016
zeehio
force-pushed the
zeehio:fix_datetimes_libreoffice
branch
from
3b7b3a0
to
a5dcd8d
Dec 7, 2016
This comment has been minimized.
This comment has been minimized.
I updated the commit message. Please note that readxl has been like this for 8 months, so the chances of this being merged in the next few days are not huge. Hopefully eventually someone will work a bit on the package and will deal with the increasing number of pull requests. (I am just another random readxl user, there is not much more I can do) |
This comment has been minimized.
This comment has been minimized.
MichaelChirico
commented
Dec 7, 2016
I hear you, there are a couple of good PRs that would improve the package a lot but it appears it's been on the shelf for some time |
This comment has been minimized.
This comment has been minimized.
@MichaelChirico readxl and these PRs will get handled in early 2017 |
hadley
assigned
jennybc
Jan 18, 2017
This comment has been minimized.
This comment has been minimized.
Looks good. Can you please add a bullet to NEWS.md? |
zeehio
added some commits
Jan 18, 2017
zeehio
force-pushed the
zeehio:fix_datetimes_libreoffice
branch
from
a5dcd8d
to
affa367
Jan 18, 2017
This comment has been minimized.
This comment has been minimized.
Rebased on master and done |
zeehio commentedMar 29, 2016
Hi,
The
dates-1900.xls
once opened and saved using LibreOffice 5 was not readable byreadxl
(it detected dates as numbers).This patch allows to detect uppercase date time formats (used at least by libreoffice). A test case is included. Note that the test fails due to different autogenerated col_names in xls and xlsx
EDIT: Excel is able to parse the file so I assumed that readxl should be capable too, otherwise the pull request would have gone to libreoffice.