Detect uppercase date time formats #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2016
zeehio
force-pushed
the
fix_datetimes_libreoffice
branch
from
3b7b3a0
to
a5dcd8d
Compare
|
I updated the commit message. Please note that readxl has been like this for 8 months, so the chances of this being merged in the next few days are not huge. Hopefully eventually someone will work a bit on the package and will deal with the increasing number of pull requests. (I am just another random readxl user, there is not much more I can do) |
|
I hear you, there are a couple of good PRs that would improve the package a lot but it appears it's been on the shelf for some time |
|
@MichaelChirico readxl and these PRs will get handled in early 2017 |
|
Looks good. Can you please add a bullet to NEWS.md? |
zeehio
force-pushed
the
fix_datetimes_libreoffice
branch
from
a5dcd8d
to
affa367
Compare
|
Rebased on master and done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The
dates-1900.xlsonce opened and saved using LibreOffice 5 was not readable byreadxl(it detected dates as numbers).This patch allows to detect uppercase date time formats (used at least by libreoffice). A test case is included. Note that the test fails due to different autogenerated col_names in xls and xlsx
EDIT: Excel is able to parse the file so I assumed that readxl should be capable too, otherwise the pull request would have gone to libreoffice.