New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective col type guessing; add CELL_UNKNOWN, COL_UNKNOWN #286

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
2 participants
@jennybc
Member

jennybc commented Mar 6, 2017

Relates to a "nice to have" mentioned in #198 (comment).

The underlying motivation was to add CELL_UNKNOWN to facilitate on-demand cell-typing (discussed in #285). But then you have to add COL_UNKNOWN to keep the enums happy. And at that point, you might as well exploit it and let people specify some col types and guess others.

I'm going to close #285 and start that effort over, after this gets reviewed and merged.

Selective col type guessing; add CELL_UNKNOWN, COL_UNKNOWN
Relates to a "nice to have" mentioned in #198
@hadley

hadley approved these changes Mar 6, 2017

@jennybc jennybc merged commit a7aaa2c into tidyverse:master Mar 6, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jennybc jennybc deleted the jennybc:selective-col-type-guessing branch Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment