New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize all paths, prior conversion to native encoding #499

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
1 participant
@jennybc
Copy link
Member

jennybc commented Aug 20, 2018

Fixes #498

Prior to b10a1a8, all xls paths were normalized, but we didn't know exactly why. In b10a1a8, I stopped normalizing xls paths, while solving an unrelated path encoding problem presented by R 3.5.

In discussion around #477, @jimhester said:

"I think doing enc2native(normalizePath()) on the R side for both xls and xlsx seems the best option."

I am now taking this wise advice.

Normalize all paths, prior conversion to native encoding
Fixes #498

Prior to b10a1a8,all xls paths were normalized, but we didn't know exactly why. In b10a1a8, I stopped normalizing xls paths, while solving an unrelated path encoding problem presented by R 3.5.

In discussion around #477, @jimhester said:

"I think doing enc2native(normalizePath()) on the R side for both xls and xlsx seems the best option."

I am now taking this wise advice.

@jennybc jennybc merged commit ad57de3 into master Aug 21, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jennybc jennybc deleted the normalize-path branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment