New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate progress via spinner #538

Merged
merged 10 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@jennybc
Copy link
Member

jennybc commented Dec 18, 2018

Closes #243 read_excel progress bar

@jennybc jennybc force-pushed the progress branch from 0c63100 to 85a0631 Dec 18, 2018

Show resolved Hide resolved src/XlsWorkSheet.h Outdated
Show resolved Hide resolved src/XlsxWorkSheet.h Outdated
Show resolved Hide resolved src/XlsxWorkSheet.h Outdated

@jennybc jennybc requested a review from hadley Dec 19, 2018

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Dec 19, 2018

@gaborcsardi I wrapped the C++ progress bar from progress here to 1) dumb it down into a spinner and 2) put it under the control of an argument on the R side. Feel free to ignore but I'm also happy to hear any feedback.

@jennybc jennybc force-pushed the progress branch from b0741cb to 9271757 Dec 19, 2018

@jennybc jennybc force-pushed the progress branch from 9271757 to 755d906 Dec 19, 2018

@hadley

hadley approved these changes Dec 19, 2018

Show resolved Hide resolved src/XlsWorkSheet.h Outdated

@jennybc jennybc merged commit 9d665bb into master Dec 19, 2018

1 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@jennybc jennybc deleted the progress branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment