Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider superscript advertising as the default #201

Closed
HughParsonage opened this issue Sep 5, 2018 · 3 comments
Closed

Consider superscript advertising as the default #201

HughParsonage opened this issue Sep 5, 2018 · 3 comments

Comments

@HughParsonage
Copy link

@HughParsonage HughParsonage commented Sep 5, 2018

I like using advertise = TRUE (the default): it's a nice acknowledgement of the package authors and a signal that it's actually a reprex.

That said, I slightly prefer

(y <- 1:4)
#> [1] 1 2 3 4
mean(y)
#> [1] 2.5

Created on 2018-09-05 by the reprex package (v0.2.0).

over

(y <- 1:4)
#> [1] 1 2 3 4
mean(y)
#> [1] 2.5

Created on 2018-09-05 by the reprex package (v0.2.0).

as the former makes the advertisement separate from the body text rather than a continuation of it. It's a matter of taste, but I thought I'd bring it up in case you like it but hadn't considered it.

Thanks!

@jennybc
Copy link
Member

@jennybc jennybc commented Sep 5, 2018

Ooh, this is an interesting idea. I'm very ambivalent about the ad (#69), but I also don't enjoy looking at horribly formatted reprexes, so we've made the default TRUE to raise awareness. I like the idea of making it less obtrusive but not suppressing entirely.

@jennybc
Copy link
Member

@jennybc jennybc commented Sep 5, 2018

I note that the <sup> tag is whitelisted on Stack Overflow, so that's good.

https://meta.stackexchange.com/questions/1777/what-html-tags-are-allowed-on-stack-exchange-sites

@HughParsonage
Copy link
Author

@HughParsonage HughParsonage commented Sep 5, 2018

@jennybc jennybc closed this in 8c64e13 Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants