Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take control of tidyverse startup message; special case of #70 #100

Merged
merged 3 commits into from
Sep 17, 2017

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Sep 17, 2017

What do you think @hadley? Conceptually and of the choice to default to TRUE instead of, say, consulting an option.

This solves a very special case of #70 Suppress package message argument, but it's also the only case that actively annoys me. The tidyverse.quiet (the official option) vs tidyverse_quiet (argname for reprex()) is a bit sad, but not sure what's better.

@jennybc jennybc requested a review from hadley September 17, 2017 21:07
@hadley
Copy link
Member

hadley commented Sep 17, 2017

I like it!

@jennybc jennybc merged commit d6b4c2c into master Sep 17, 2017
@jennybc jennybc deleted the shhhh-tidyverse branch September 17, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants