-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use read_utf8() and write_utf8() #237
Conversation
What's the status of this PR @krlmlr? Is "WIP" still accurate or should it be considered "ready to go"? |
I think using Removed the AppVeyor cache to fix the broken build, also turned on binary installation. Let's see what the Windows test shows. |
I guess we're good to go here. |
OK I will experiment with this personally over on Windows. |
Both wrap their xfun equivalents
I can imagine we'll need refinements. And I'd like to add tests that means something. But this seems like (the first) step in the right direction. Merging. |
Thanks. I don't think the caching on AppVeyor is currently worth its price, especially if installation from binary is enabled. If problems occur again, we can cherry-pick 03c0d5a. |
from xfun, which is a dependency anyway via rmarkdown -> knitr. This fixes encoding problems on non-Latin locales.
Was meant to address #234, but can't fix it unfortunately.