Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read_utf8() and write_utf8() #237

Merged
merged 7 commits into from May 18, 2019
Merged

Use read_utf8() and write_utf8() #237

merged 7 commits into from May 18, 2019

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 23, 2019

from xfun, which is a dependency anyway via rmarkdown -> knitr. This fixes encoding problems on non-Latin locales.

Was meant to address #234, but can't fix it unfortunately.

@krlmlr krlmlr changed the title Use read_utf8() and write_utf8() WIP: Use read_utf8() and write_utf8() Jan 23, 2019
@jennybc
Copy link
Member

@jennybc jennybc commented May 15, 2019

What's the status of this PR @krlmlr? Is "WIP" still accurate or should it be considered "ready to go"?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 15, 2019

I think using read_utf8() etc. is better than the current implementation, but it won't fix the bug that triggered this PR.

Removed the AppVeyor cache to fix the broken build, also turned on binary installation. Let's see what the Windows test shows.

@krlmlr krlmlr changed the title WIP: Use read_utf8() and write_utf8() Use read_utf8() and write_utf8() May 15, 2019
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 15, 2019

I guess we're good to go here.

@jennybc
Copy link
Member

@jennybc jennybc commented May 16, 2019

OK I will experiment with this personally over on Windows.

appveyor.yml Outdated Show resolved Hide resolved
@jennybc
Copy link
Member

@jennybc jennybc commented May 18, 2019

I can imagine we'll need refinements. And I'd like to add tests that means something. But this seems like (the first) step in the right direction. Merging.

@jennybc jennybc merged commit e10e553 into tidyverse:master May 18, 2019
1 of 2 checks passed
@krlmlr krlmlr deleted the f-xfun branch May 19, 2019
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 19, 2019

Thanks. I don't think the caching on AppVeyor is currently worth its price, especially if installation from binary is enabled. If problems occur again, we can cherry-pick 03c0d5a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants