Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to reprex from an expression as an argument, closes #2. #6

Merged
merged 2 commits into from Sep 12, 2015

Conversation

@dgrtwo
Copy link
Member

commented Aug 26, 2015

Set up to work from a tempfile(), or to take an output filename as an argument, closes #4.

Added tests for clipboard read/write/copy and for a simple reprex example from the clipboard or from an expression.

This was, um, a lot of breaking changes. I probably should have started by adding the expression, then considering temporary and output files, but I found myself making both changes at once. We should definitely discuss issue #4 if you don't like the new approach, and I can extract it out from the other changes.

(Note that reprexing from an expression involved separating reprex into two functions, reprex and reprex_. This is loosely based on lazyeval's recommendations. The end user doesn't have to worry about reprex_ though).

dgrtwo added some commits Aug 26, 2015

Added ability to reprex from an expression as an argument, closes #2.
Set up to work from a tempfile(), or to take an output filename as an argument, closes #4.

Added tests for clipboard read/write/copy and for a simple reprex example from the clipboard or from an expression.
Added a session_info argument, which appends devtools::session_info()…
… to the code. This would close #5.

Fixed a small bug where the browser window was opened even when show = FALSE.
@jennybc

This comment has been minimized.

Copy link
Member

commented Sep 12, 2015

Thanks for this!

It appears this broke the feature where the rendered html shows up in RStudio's Viewer. I haven't tried to figure that out yet, though. I have alot to digest about this PR.

But if you can figure out how to restore that, I'd be all smiles.

@jennybc

This comment has been minimized.

Copy link
Member

commented Sep 12, 2015

Also you should add yourself as an aut. Or I will.

@jennybc

This comment has been minimized.

Copy link
Member

commented Sep 12, 2015

Nevermind about the Viewer thing. I am figuring it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.