Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid scraping IMDB in readme/vignettes #195

Closed
HBossier opened this issue May 6, 2017 · 2 comments
Closed

Avoid scraping IMDB in readme/vignettes #195

HBossier opened this issue May 6, 2017 · 2 comments

Comments

@HBossier
Copy link

HBossier commented May 6, 2017

Hello,

Bit a silly comment and possibly it has been given before (though I could not find it in the issues list).
But the Conditions of Use from IMDb explicitly state that:

Robots and Screen Scraping: You may not use data mining, robots, screen scraping, or similar data gathering and extraction tools on this site, except with our express written consent as noted below.

Hence, unless this consent has been given, you might want to change the demo given in the README in order to stay safe...

IMDb conditions

@hadley
Copy link
Member

hadley commented Dec 20, 2020

This example is also used in both vignettes, so we'd need to change it there too. The question is what to change it too — ideally it should be something that is unlikely to change in the future.

@hadley hadley changed the title Demo on IMDB Avoid scraping IMDB in readme/vignettes Dec 20, 2020
@hadley
Copy link
Member

hadley commented Jan 5, 2021

Best bet is to create some example vignettes suitable for scraping. Can use https://scrapethissite.com/pages/ for inspiration.

hadley added a commit that referenced this issue Jan 6, 2021
Eliminates last use of imdb data, fixing #195.
@hadley hadley closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants