Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make html_table() handle blank rowspan and colspan attributes #323

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Make html_table() handle blank rowspan and colspan attributes #323

merged 5 commits into from
Jul 14, 2021

Conversation

epiben
Copy link
Contributor

@epiben epiben commented Jul 13, 2021

Solves #322.
With these additions, code such as <table><tr><td rowspan=''>cell content</td></tr></table> will produce the expected result. The issue presents several other examples.

@hadley
Copy link
Member

hadley commented Jul 13, 2021

Could you please add a couple of unit tests?

@epiben
Copy link
Contributor Author

epiben commented Jul 14, 2021

Of course, my bad. I added two fairly simple tests, but they should do the trick.

R/table.R Show resolved Hide resolved
@hadley hadley merged commit 3dbe938 into tidyverse:master Jul 14, 2021
@hadley
Copy link
Member

hadley commented Jul 14, 2021

Thanks!

@epiben
Copy link
Contributor Author

epiben commented Jul 15, 2021

Happy to contribute, if even just a tiny bit for now. Thanks for a pleasant review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants