Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle blank tables #327

Merged
merged 6 commits into from Jul 30, 2021
Merged

Handle blank tables #327

merged 6 commits into from Jul 30, 2021

Conversation

epiben
Copy link
Contributor

@epiben epiben commented Jul 27, 2021

Fixes #324. Enables html_table to correctly convert empty tables to empty tibbles. Empty tables are a bit of an oddity, but they do exist and this way at least they're handled. Will add a NEWS entry once I have the PR id.

@hadley hadley merged commit 4a1d876 into tidyverse:master Jul 30, 2021
@hadley
Copy link
Member

hadley commented Jul 30, 2021

Thanks @epiben! Unfortunately it didn't make it into 1.0.1 because I needed to push out a quick release for an example that was failing on CRAN.

@epiben
Copy link
Contributor Author

epiben commented Jul 30, 2021

My pleasure! For CRAN, no worries; saw that they crossed so should've been faster 😀 -- It'll just come out with the next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty tables break html_table()
2 participants