Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str_view_all behaves poorly within Notebooks #232

Closed
kevinushey opened this issue Mar 29, 2018 · 0 comments
Closed

str_view_all behaves poorly within Notebooks #232

kevinushey opened this issue Mar 29, 2018 · 0 comments

Comments

@kevinushey
Copy link

@kevinushey kevinushey commented Mar 29, 2018

rstudio/rstudio#2174
rstudio/rstudio#2533

Rather than allowing the widget to grow in height unboundedly with a large number of matches, perhaps the widget should instead clamp its contents to a div with a maximum height, and allow for internal scrolling? (Note that this scrolling won't work within the IDE but would work within the rendered document)

@hadley hadley closed this in cf30ac1 May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant