Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error messages #61

Closed
ctbrown opened this issue Mar 30, 2015 · 3 comments
Closed

Incorrect error messages #61

ctbrown opened this issue Mar 30, 2015 · 3 comments

Comments

@ctbrown
Copy link

@ctbrown ctbrown commented Mar 30, 2015

For dev version: 0.9.0.9000

Error messages ask user to use regexp function; the function appears to be named regex. See for

> packageVersion('stringr')
[1] "0.9.0.9000"

> perl("test")
perl is deprecated. Please use regexp instead
...

> ignore.case("test")
Please use (fixed|coll|regexp)(x, ignore_case = TRUE) instead of ignore.case(x)
...
> 

And this:

type.regexp <- function(x) "regex"

Seems that there is some more general confusion between regex and regexp. Outside of R, I believe regex is more common. I would nominate using regex

@gagolews
Copy link
Contributor

@gagolews gagolews commented May 1, 2015

👍

@eddelbuettel
Copy link

@eddelbuettel eddelbuettel commented May 3, 2015

This seems to be a mere typo as stringr::regex exists whereas stringr::regexp does not:

R> stringr::regex
function (pattern, ignore_case = FALSE, multiline = FALSE, comments = FALSE, 
    dotall = FALSE, ...) 
{
    options <- stri_opts_regex(case_insensitive = ignore_case, 
        multiline = multiline, comments = comments, dotall = dotall, 
        ...)
    structure(pattern, options = options, class = c("regex", 
        "pattern", "character"))
}
<environment: namespace:stringr>
R> stringr::regexp
Error: 'regexp' is not an exported object from 'namespace:stringr'
R> 
@tyner
Copy link

@tyner tyner commented May 20, 2016

Just curious, when is the next anticipated release to CRAN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants