Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added str_remove() and str_remove_all() #178

Merged
merged 7 commits into from Nov 15, 2017
Merged

Added str_remove() and str_remove_all() #178

merged 7 commits into from Nov 15, 2017

Conversation

@Shians
Copy link
Contributor

@Shians Shians commented Aug 2, 2017

This is just an alias for str_replace(string, pattern, "") but I feel like it's a common enough usage to deserve its own functions.

@hadley
Copy link
Member

@hadley hadley commented Nov 14, 2017

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

Thanks!

@Shians
Copy link
Contributor Author

@Shians Shians commented Nov 14, 2017

Thanks Hadley, I've updated the NEWS.

@hadley hadley merged commit 692aaa0 into tidyverse:master Nov 15, 2017
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 100%)
Details
@codecov
codecov/project 100% (+0%) compared to 48d283c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley
Copy link
Member

@hadley hadley commented Nov 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants