New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess whitespace removal throughout a string #197

Merged
merged 3 commits into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@stephlocke
Contributor

stephlocke commented Nov 19, 2017

Function uses str_replace() and stri_trim_both() to remove excess spaces.

stephlocke added some commits Nov 19, 2017

@stephlocke

This comment has been minimized.

Contributor

stephlocke commented Nov 19, 2017

@hadley - new PR with requested stuff from #177

@stephlocke stephlocke changed the title from str_squish (per #177) to enable excess whitespace removal throughout a string to Excess whitespace removal throughout a string Nov 19, 2017

NEWS.md Outdated
@@ -12,6 +12,8 @@
* `str_remove()` and `str_remove_all()` functions. These wrap
`str_replace()` and `str_replace_all()` to remove patterns from strings.
(@Shians, #178)
* `str_squish()` removes excess spaces from both the left and right side of strings. (@stephlocke #197)

This comment has been minimized.

@hadley

hadley Nov 20, 2017

Member

And the middle?

This comment has been minimized.

@stephlocke

stephlocke Nov 20, 2017

Contributor

Good spot

Added: b171a5e

@hadley hadley merged commit 17515f2 into tidyverse:master Nov 20, 2017

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to aac9f53
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Nov 20, 2017

Thanks!

hadley added a commit that referenced this pull request Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment