Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong width calculation for non-syntactic names #258

Closed
krlmlr opened this issue May 19, 2017 · 1 comment
Closed

Wrong width calculation for non-syntactic names #258

krlmlr opened this issue May 19, 2017 · 1 comment

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 19, 2017

They are escaped twice, tibbles with many such columns may have columns removed without apparent reason.

print(tibble::tibble("mean(x)" = 5, "var(x)" = 3), width = 28)
#> # A tibble: 1 x 2
#>   `mean(x)`
#>       <dbl>
#> 1         5
#> # ... with 1 more
#> #   variables:
#> #   `var(x)` <dbl>
@krlmlr krlmlr closed this in 70cacf0 May 19, 2017
krlmlr added a commit that referenced this issue May 27, 2017
- Fix error in `tidy_names(syntactic = TRUE, quiet = FALSE)` if not all names are fixed (#260, @imanuelcostigan).
- The column width for non-syntactic columns is computed correctly again (#258).
- The `print.tbl_df()` method is identical to `print.tbl()`, instead of calling `NextMethod()`, to protect against malformed tibbles that inherit from `"tbl_df"` but not `"tbl"`, as created e.g. by `ungroup()` in dplyr 0.5.0 and earlier.
- Remove unused import declaration for assertthat.
krlmlr added a commit that referenced this issue May 27, 2017
- Fix error in `tidy_names(syntactic = TRUE, quiet = FALSE)` if not all names are fixed (#260, @imanuelcostigan).
- The column width for non-syntactic columns is computed correctly again (#258).
- The `print.tbl_df()` method is identical to `print.tbl()`, instead of calling `NextMethod()`, to protect against malformed tibbles that inherit from `"tbl_df"` but not `"tbl"`, as created e.g. by `ungroup()` in dplyr 0.5.0 and earlier.
- Remove unused import declaration for assertthat.
krlmlr added a commit that referenced this issue May 29, 2017
- Added `format()` and `print()` methods for both `tbl` and `tbl_df` classes, to protect against malformed tibbles that inherit from `"tbl_df"` but not `"tbl"`, as created e.g. by `ungroup()` in dplyr 0.5.0 and earlier (#256, #263).
- The column width for non-syntactic columns is computed correctly again (#258).
- Printing a tibble doesn't apply quote escaping to list columns.
- Fix error in `tidy_names(syntactic = TRUE, quiet = FALSE)` if not all names are fixed (#260, @imanuelcostigan).
- Remove unused import declaration for assertthat.
@github-actions
Copy link

@github-actions github-actions bot commented Dec 13, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant