New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make information more consistent for glimpse() and print() methods? #280

Closed
dalejbarr opened this Issue Jul 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@dalejbarr

dalejbarr commented Jul 25, 2017

It would be nice if the information displayed about tables was more consistent across print() and glimpse(). I have noticed these two differences:

  1. Currently, print() informs the user about any data groupings, but glimpse() does not

  2. Column names that contain special characters (e.g., white space) are displayed with back ticks by print() but not by glimpse(). If, for instance, a column name ends with a space, the user is only alerted to this potential problem if print() is used

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jul 27, 2017

Thanks. The first item requires a change in dplyr, could you please bring it up there? I'll add backticks for column names in glimpse().

@krlmlr krlmlr closed this in 9d62f68 Jul 27, 2017

krlmlr added a commit that referenced this issue Jul 28, 2017

Merge tag 'v1.3.3.9001'
- Escape factor levels when printing (#277).
- Adding columns to zero-row data frames now also works when mixing
lengths 1 and 0 in the new columns (#167).
- Non-syntactic names are now also escaped in `glimpse()` (#280).
- The `validate` argument is now also supported in `as_tibble.tbl_df()`,
with default to `FALSE` (#278).

krlmlr added a commit that referenced this issue Aug 22, 2017

Merge tag 'v1.3.4'
Bug fixes
---------

- Values of length 1 in a `tibble()` call are recycled prior to evaluating subsequent arguments, improving consistency with `mutate()` (#213).
- Recycling of values of length 1 in a `tibble()` call maintains their class (#284).
- `add_row()` now always preserves the column data types of the input data frame the same way as `rbind()` does (#296).
- `lst()` now again handles duplicate names, the value defined last is used in case of a clash.
- Adding columns to zero-row data frames now also works when mixing lengths 1 and 0 in the new columns (#167).
- The `validate` argument is now also supported in `as_tibble.tbl_df()`, with default to `FALSE` (#278).  It must be passed as named argument, as in `as_tibble(validate = TRUE)`.

Formatting
----------

- `format_v()` now always surrounds lists with `[]` brackets, even if their length is one. This affects `glimpse()` output for list columns (#106).
- Factor levels are escaped when printing (#277).
- Non-syntactic names are now also escaped in `glimpse()` (#280).
- `tibble()` gives a consistent error message in the case of duplicate column names (#291).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment