Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enframe(NULL) #352

Closed
hadley opened this issue Jan 4, 2018 · 3 comments
Closed

enframe(NULL) #352

hadley opened this issue Jan 4, 2018 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented Jan 4, 2018

Should return a zero row tibble.
@krlmlr
Copy link
Member

krlmlr commented Jan 4, 2018

What type should the value column have?

tibble::enframe(character())
#> # A tibble: 0 x 2
#> # ... with 2 variables: name <int>, value <chr>

Created on 2018-01-04 by the reprex package (v0.1.1.9000).

@hadley
Copy link
Member Author

hadley commented Jan 4, 2018

Probably logical

@krlmlr krlmlr closed this as completed in 1323883 Jan 20, 2018
krlmlr added a commit that referenced this issue Jan 20, 2018
@krlmlr
Merge tag 'v1.4.1.9001'
782c890 
- `enframe(NULL)` now returns the same as `enframe(logical())` (#352).
- `tbl[1, , drop = TRUE]` now behaves identically to data frames (#367).
- The `tibble.width` option is honored again (#369).
- Faster printing of very wide tibbles (#360).
- Update vignette to match changes in 1.4.1 (#368, @bgreenwell).
- Don't rely on `ncol()` for `glimpse()`, only query `nrow()` and `head()`.
- Return input for zero-column data frames.
- Add test for `glimpse()` with unknown rows (#366, @kevinykuo).
- Faster construction and subsetting for tibbles (#353).
- `tribble()` now ignores trailing commas (#342, @LaDilettante).
- Fix error message when accessing columns using a logical index vector (#337, @mundl).
krlmlr added a commit that referenced this issue Jan 23, 2018
@krlmlr
Merge tag 'v1.4.2'
60a753c 
Bug fixes
---------

- Fix OS X builds.
- The `tibble.width` option is honored again (#369).
- `tbl[1, , drop = TRUE]` now behaves identically to data frames (#367).
- Fix error message when accessing columns using a logical index vector (#337, @mundl).
- `glimpse()` returns its input for zero-column data frames.

Features
--------

- `enframe(NULL)` now returns the same as `enframe(logical())` (#352).
- `tribble()` now ignores trailing commas (#342, @LaDilettante).
- Updated vignettes and website documentation.

Performance
-----------

- Faster printing of very wide tibbles (#360).
- Faster construction and subsetting for tibbles (#353).
- Only call `nrow()` and `head()` in `glimpse()`, not `ncol()`.
@krlmlr krlmlr mentioned this issue Feb 28, 2018
Closed
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @krlmlr