New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_tibble() checks column length twice #365

Closed
krlmlr opened this Issue Jan 15, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@krlmlr
Copy link
Member

krlmlr commented Jan 15, 2018

even with validate = FALSE. This seems unnecessary.

@krlmlr krlmlr added the performance label Jan 15, 2018

@anhqle

This comment has been minimized.

Copy link
Contributor

anhqle commented Jan 24, 2018

So do we make the validate_nrow check from new_tibble optional?

This preserves the ability to validate_nrow for authors who use new_tibble to extend tibble, while allowing us to skip validate_nrow in as_tibble.

PR below.

anhqle added a commit to anhqle/tibble that referenced this issue Jan 24, 2018

anhqle added a commit to anhqle/tibble that referenced this issue Jan 29, 2018

anhqle added a commit to anhqle/tibble that referenced this issue Jan 31, 2018

anhqle added a commit to anhqle/tibble that referenced this issue Jan 31, 2018

@krlmlr krlmlr closed this in 9161a84 Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment