Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_tibble() checks column length twice #365

Closed
krlmlr opened this issue Jan 15, 2018 · 2 comments
Closed

as_tibble() checks column length twice #365

krlmlr opened this issue Jan 15, 2018 · 2 comments

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 15, 2018

even with validate = FALSE. This seems unnecessary.

@anhqle
Copy link
Contributor

@anhqle anhqle commented Jan 24, 2018

So do we make the validate_nrow check from new_tibble optional?

This preserves the ability to validate_nrow for authors who use new_tibble to extend tibble, while allowing us to skip validate_nrow in as_tibble.

PR below.

anhqle added a commit to anhqle/tibble that referenced this issue Jan 24, 2018
anhqle added a commit to anhqle/tibble that referenced this issue Jan 29, 2018
anhqle added a commit to anhqle/tibble that referenced this issue Jan 31, 2018
anhqle added a commit to anhqle/tibble that referenced this issue Jan 31, 2018
@krlmlr krlmlr closed this in 9161a84 Jan 31, 2018
@github-actions
Copy link

@github-actions github-actions bot commented Dec 11, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants