Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_tibble() drops grouped_df class #535

Closed
krlmlr opened this issue Nov 10, 2018 · 2 comments
Closed

as_tibble() drops grouped_df class #535

krlmlr opened this issue Nov 10, 2018 · 2 comments
Milestone

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 10, 2018

From rnabioco/valr#338 (comment):

6d53680

library(tidyverse)

tibble(a = 1:3) %>%
  group_by(a) %>%
  as_tibble()
#> # A tibble: 3 x 1
#>       a
#>   <int>
#> 1     1
#> 2     2
#> 3     3

Created on 2018-11-10 by the reprex package (v0.2.1.9000)

v1.4.2

library(tidyverse)

tibble(a = 1:3) %>%
  group_by(a) %>%
  as_tibble()
#> # A tibble: 3 x 1
#> # Groups:   a [3]
#>       a
#>   <int>
#> 1     1
#> 2     2
#> 3     3

Created on 2018-11-10 by the reprex package (v0.2.1)

Options

  • Document as breaking change (this would be consistent with #181 and with the current behavior of as.data.frame())
  • Revisit (needs a test too)
@krlmlr krlmlr added this to the 2.0.0 milestone Nov 22, 2018
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 22, 2018

Document as breaking change.

@github-actions
Copy link

@github-actions github-actions bot commented Dec 9, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant