Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view function incorrectly shows objects named x #579

Closed
aimeegott opened this issue Feb 20, 2019 · 6 comments
Closed

view function incorrectly shows objects named x #579

aimeegott opened this issue Feb 20, 2019 · 6 comments
Milestone

Comments

@aimeegott
Copy link

@aimeegott aimeegott commented Feb 20, 2019

When an object exists in the global environment named x, the view function shows that object even if a data frame is passed to it

library(tibble)
x <- 10
view(mtcars)
@krlmlr krlmlr added this to the 2.x.y milestone Feb 22, 2019
@krlmlr krlmlr closed this in 30d8d8e Feb 22, 2019
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 22, 2019

Thanks for raising this.

@lionel-: Why would enexpr() have the side effect of throwing away the environment for x when accessing it using regular evaluation after calling it?

@lionel-
Copy link
Member

@lionel- lionel- commented Feb 22, 2019

I don't understand the question.

@krlmlr krlmlr reopened this Feb 22, 2019
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 22, 2019

I was confused, sorry.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 22, 2019

@jmcphers: I think the RStudio hook is ultimately responsible for this problem. We can work around, but would you consider rewriting to use tidy evaluation?

https://github.com/rstudio/rstudio/blame/master/src/cpp/session/modules/SessionDataViewer.R#L645-L646

@krlmlr krlmlr closed this in 33c08cc Feb 22, 2019
@jmcphers
Copy link

@jmcphers jmcphers commented Feb 22, 2019

Yes, we should fix this on the RStudio side. The tracking bug is here:

rstudio/rstudio#3304

@github-actions
Copy link

@github-actions github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants