Use num_as_location(oob = "extend") internally

[krlmlr]

for subassignment.

@lionel-: Is this a good idea for tibble 3.0.0?

[lionel-]

I think so. I implemented this for tibble :)

[krlmlr]

Do we want to support the oob argument for vec_as_location() too, for character input? This would then fill OOB values with indices.

Would it be too bad if vec_as_location() returned a named vector for character input?

[lionel-]

Do we want to support the oob argument for vec_as_location() too, for character input? This would then fill OOB values with indices.

Can you show an example please?

Would it be too bad if vec_as_location() returned a named vector for character input?

This isn't possible because we preserve the names of the subscript vector.

[krlmlr]

Works already

i <- c(1, 2, 4, 3)
i <- rlang::set_names(i, letters[i])
i
#> a b d c 
#> 1 2 4 3
vctrs::num_as_location(i, 3, oob = "extend")
#> a b d c 
#> 1 2 4 3

Desired behavior

i <- c(1, 2, 4, 3)
i <- rlang::set_names(letters[i])
i
#>   a   b   d   c 
#> "a" "b" "d" "c"
vctrs::vec_as_location(i, 3, letters[1:3], oob = "extend")
#> a b d c 
#> 1 2 4 3

^{Created on 2020-03-26 by the reprex package (v0.3.0)}

[krlmlr]

Requires r-lib/vctrs#1166.

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.