Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing cli leads to weird downstream errors #754

Closed
krlmlr opened this issue Apr 3, 2020 · 6 comments
Closed

Importing cli leads to weird downstream errors #754

krlmlr opened this issue Apr 3, 2020 · 6 comments
Milestone

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 3, 2020

ropensci/RNeXML#247 (comment)

loadNamespace("RNeXML")
#> <environment: namespace:RNeXML>
unloadNamespace("RNeXML")
#> Error in .mergeMethodsTable(generic, mtable, tt, attach): trying to get slot "defined" from an object of a basic class ("environment") with no slots

Created on 2020-04-03 by the reprex package (v0.3.0)

Testing requires reinstalling the tibble package!

Changing cli doesn't seem to help, need to double-check (change, reinstall tibble, reinstall RNeXML, test).

Workaround: Remove #' @importFrom cli ...

@krlmlr krlmlr added this to the 3.0.1 milestone Apr 3, 2020
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 8, 2020

Working around for now, CC @gaborcsardi.

@krlmlr krlmlr closed this as completed in 1bdc0cf Apr 8, 2020
@gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Apr 8, 2020

So what is happening here? I suspect the active binding is causing trouble, but how?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 8, 2020

I also suspected the active binding but couldn't replicate. Note that you really need to build/install cli and tibble for testing, perhaps also the downstream package if you use that for testing.

On a side note, can we soft-deprecate symbol in favor of cli_symbol(x) which really shouldn't be much slower now that we're using an active binding?

@gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Apr 8, 2020

Lots of packages use symbol, so I would repair this some other way.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Apr 8, 2020

cli_symbol() was about clarity for new code.

krlmlr added a commit that referenced this issue Feb 25, 2021
tibble 3.0.1

- `[<-.tbl_df()` coerces matrices to data frames (#762).

- Use delayed import for cli to work around unload problems in downstream packages (#754).

- More soft-deprecation warnings are actually visible.

- If `.name_repair` is a function, no repair messages are shown (#763).

- Remove superseded signal for `as_tibble.list()`, because `as_tibble_row()` only works for size 1.

- `as_tibble(validate = )` now always triggers a deprecation warning.

- Subsetting and subassignment of rows with one-column matrices work again, with a deprecation warning (#760).

- Attempts to update a tibble row with an atomic vector give a clearer error message. Recycling message for subassignment appears only if target size is != 1.

- Tweak title of "Invariants" vignette.
@github-actions
Copy link

@github-actions github-actions bot commented Apr 9, 2021

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants