Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs_dots warning when printing a tibble #798

Closed
yutannihilation opened this issue Jul 10, 2020 · 8 comments
Closed

needs_dots warning when printing a tibble #798

yutannihilation opened this issue Jul 10, 2020 · 8 comments

Comments

@yutannihilation
Copy link
Member

yutannihilation commented Jul 10, 2020

I don't find where this issue comes from, but seems the latest version of tibble causes this warning.

tibble::tibble(a = 1)
#> Warning: `...` is not empty.
#> 
#> We detected these problematic arguments:
#> * `needs_dots`
#> 
#> These dots only exist to allow future extensions and should be empty.
#> Did you misspecify an argument?
#> # A tibble: 1 x 1
#>       a
#>   <dbl>
#> 1     1

Created on 2020-07-10 by the reprex package (v0.3.0)

@krlmlr
Copy link
Member

krlmlr commented Jul 10, 2020

Thanks. I'm seeing:

tibble::tibble(a = 1)
#> # A tibble: 1 x 1
#>       a
#>   <dbl>
#> 1     1

Created on 2020-07-10 by the reprex package (v0.3.0)

Session info
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 4.0.2 (2020-06-22)
#>  os       Ubuntu 18.04.4 LTS          
#>  system   x86_64, linux-gnu           
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       Europe/Zurich               
#>  date     2020-07-10                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source        
#>  assertthat    0.2.1      2019-03-21 [2] RSPM (R 4.0.0)
#>  backports     1.1.8      2020-06-17 [2] RSPM (R 4.0.1)
#>  callr         3.4.3      2020-03-28 [2] RSPM (R 4.0.0)
#>  cli           2.0.2      2020-02-28 [2] RSPM (R 4.0.0)
#>  crayon        1.3.4      2017-09-16 [2] RSPM (R 4.0.0)
#>  desc          1.2.0      2018-05-01 [2] RSPM (R 4.0.0)
#>  devtools      2.3.0      2020-04-10 [2] RSPM (R 4.0.0)
#>  digest        0.6.25     2020-02-23 [2] RSPM (R 4.0.0)
#>  ellipsis      0.3.1      2020-05-15 [2] RSPM (R 4.0.0)
#>  evaluate      0.14       2019-05-28 [2] RSPM (R 4.0.0)
#>  fansi         0.4.1      2020-01-08 [2] RSPM (R 4.0.0)
#>  fs            1.4.2      2020-06-30 [2] RSPM (R 4.0.2)
#>  glue          1.4.1      2020-05-13 [2] RSPM (R 4.0.0)
#>  highr         0.8        2019-03-20 [2] RSPM (R 4.0.0)
#>  htmltools     0.5.0      2020-06-16 [2] RSPM (R 4.0.1)
#>  knitr         1.29       2020-06-23 [2] RSPM (R 4.0.2)
#>  lifecycle     0.2.0      2020-03-06 [2] RSPM (R 4.0.0)
#>  magrittr      1.5        2014-11-22 [2] RSPM (R 4.0.0)
#>  memoise       1.1.0      2017-04-21 [2] RSPM (R 4.0.0)
#>  pillar        1.4.4      2020-05-05 [2] RSPM (R 4.0.0)
#>  pkgbuild      1.0.8      2020-05-07 [2] RSPM (R 4.0.0)
#>  pkgconfig     2.0.3      2019-09-22 [2] RSPM (R 4.0.0)
#>  pkgload       1.1.0.9000 2020-06-04 [1] local         
#>  prettyunits   1.1.1      2020-01-24 [2] RSPM (R 4.0.0)
#>  processx      3.4.3      2020-07-05 [2] RSPM (R 4.0.2)
#>  ps            1.3.3      2020-05-08 [2] RSPM (R 4.0.0)
#>  purrr         0.3.4      2020-04-17 [2] RSPM (R 4.0.0)
#>  R6            2.4.1      2019-11-12 [2] RSPM (R 4.0.0)
#>  remotes       2.1.1      2020-02-15 [2] RSPM (R 4.0.0)
#>  reprex        0.3.0      2019-05-16 [2] RSPM (R 4.0.0)
#>  rlang         0.4.7      2020-07-09 [1] local         
#>  rmarkdown     2.3        2020-06-18 [2] RSPM (R 4.0.1)
#>  rprojroot     1.3-2      2018-01-03 [2] RSPM (R 4.0.0)
#>  sessioninfo   1.1.1      2018-11-05 [2] RSPM (R 4.0.0)
#>  stringi       1.4.6      2020-02-17 [2] RSPM (R 4.0.0)
#>  stringr       1.4.0      2019-02-10 [2] RSPM (R 4.0.0)
#>  testthat      2.3.2      2020-03-02 [2] RSPM (R 4.0.0)
#>  tibble        3.0.2      2020-07-07 [1] local         
#>  usethis       1.6.1.9001 2020-07-09 [1] local         
#>  utf8          1.1.4      2018-05-24 [2] RSPM (R 4.0.0)
#>  vctrs         0.3.1      2020-06-05 [2] RSPM (R 4.0.0)
#>  withr         2.2.0      2020-04-20 [2] RSPM (R 4.0.0)
#>  xfun          0.15       2020-06-21 [2] RSPM (R 4.0.1)
#>  yaml          2.2.1      2020-02-01 [2] RSPM (R 4.0.0)
#> 
#> [1] /home/kirill/R-dev
#> [2] /home/kirill/R/x86_64-pc-linux-gnu-library/4.0
#> [3] /usr/local/lib/R/site-library
#> [4] /usr/lib/R/site-library
#> [5] /usr/lib/R/library

Can you please post your session info?

@krlmlr
Copy link
Member

krlmlr commented Jul 10, 2020

Confirmed with pillar 1.4.5:

tibble::tibble(a = 1)
#> Warning: `...` is not empty.
#> 
#> We detected these problematic arguments:
#> * `needs_dots`
#> 
#> These dots only exist to allow future extensions and should be empty.
#> Did you misspecify an argument?
#> # A tibble: 1 x 1
#>       a
#>   <dbl>
#> 1     1

Created on 2020-07-10 by the reprex package (v0.3.0)

Session info
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 4.0.2 (2020-06-22)
#>  os       Ubuntu 18.04.4 LTS          
#>  system   x86_64, linux-gnu           
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       Europe/Zurich               
#>  date     2020-07-10                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source        
#>  assertthat    0.2.1      2019-03-21 [2] RSPM (R 4.0.0)
#>  backports     1.1.8      2020-06-17 [2] RSPM (R 4.0.1)
#>  callr         3.4.3      2020-03-28 [2] RSPM (R 4.0.0)
#>  cli           2.0.2      2020-02-28 [2] RSPM (R 4.0.0)
#>  crayon        1.3.4      2017-09-16 [2] RSPM (R 4.0.0)
#>  desc          1.2.0      2018-05-01 [2] RSPM (R 4.0.0)
#>  devtools      2.3.0      2020-04-10 [2] RSPM (R 4.0.0)
#>  digest        0.6.25     2020-02-23 [2] RSPM (R 4.0.0)
#>  ellipsis      0.3.1      2020-05-15 [2] RSPM (R 4.0.0)
#>  evaluate      0.14       2019-05-28 [2] RSPM (R 4.0.0)
#>  fansi         0.4.1      2020-01-08 [2] RSPM (R 4.0.0)
#>  fs            1.4.2      2020-06-30 [2] RSPM (R 4.0.2)
#>  glue          1.4.1      2020-05-13 [2] RSPM (R 4.0.0)
#>  highr         0.8        2019-03-20 [2] RSPM (R 4.0.0)
#>  htmltools     0.5.0      2020-06-16 [2] RSPM (R 4.0.1)
#>  knitr         1.29       2020-06-23 [2] RSPM (R 4.0.2)
#>  lifecycle     0.2.0      2020-03-06 [2] RSPM (R 4.0.0)
#>  magrittr      1.5        2014-11-22 [2] RSPM (R 4.0.0)
#>  memoise       1.1.0      2017-04-21 [2] RSPM (R 4.0.0)
#>  pillar        1.4.5.9000 2020-07-10 [1] local         
#>  pkgbuild      1.0.8      2020-05-07 [2] RSPM (R 4.0.0)
#>  pkgconfig     2.0.3      2019-09-22 [2] RSPM (R 4.0.0)
#>  pkgload       1.1.0.9000 2020-06-04 [1] local         
#>  prettyunits   1.1.1      2020-01-24 [2] RSPM (R 4.0.0)
#>  processx      3.4.3      2020-07-05 [2] RSPM (R 4.0.2)
#>  ps            1.3.3      2020-05-08 [2] RSPM (R 4.0.0)
#>  purrr         0.3.4      2020-04-17 [2] RSPM (R 4.0.0)
#>  R6            2.4.1      2019-11-12 [2] RSPM (R 4.0.0)
#>  remotes       2.1.1      2020-02-15 [2] RSPM (R 4.0.0)
#>  reprex        0.3.0      2019-05-16 [2] RSPM (R 4.0.0)
#>  rlang         0.4.7      2020-07-09 [1] local         
#>  rmarkdown     2.3        2020-06-18 [2] RSPM (R 4.0.1)
#>  rprojroot     1.3-2      2018-01-03 [2] RSPM (R 4.0.0)
#>  sessioninfo   1.1.1      2018-11-05 [2] RSPM (R 4.0.0)
#>  stringi       1.4.6      2020-02-17 [2] RSPM (R 4.0.0)
#>  stringr       1.4.0      2019-02-10 [2] RSPM (R 4.0.0)
#>  testthat      2.3.2      2020-03-02 [2] RSPM (R 4.0.0)
#>  tibble        3.0.2      2020-07-07 [1] local         
#>  usethis       1.6.1.9001 2020-07-09 [1] local         
#>  utf8          1.1.4      2018-05-24 [2] RSPM (R 4.0.0)
#>  vctrs         0.3.1      2020-06-05 [2] RSPM (R 4.0.0)
#>  withr         2.2.0      2020-04-20 [2] RSPM (R 4.0.0)
#>  xfun          0.15       2020-06-21 [2] RSPM (R 4.0.1)
#>  yaml          2.2.1      2020-02-01 [2] RSPM (R 4.0.0)
#> 
#> [1] /home/kirill/R-dev
#> [2] /home/kirill/R/x86_64-pc-linux-gnu-library/4.0
#> [3] /usr/local/lib/R/site-library
#> [4] /usr/lib/R/site-library
#> [5] /usr/lib/R/library

@krlmlr krlmlr closed this as completed in a384b33 Jul 10, 2020
@yutannihilation
Copy link
Member Author

yutannihilation commented Jul 10, 2020

Thanks for fixing so quick!

@amitcs003
Copy link

amitcs003 commented Jul 21, 2020

What is the resolution?

@krlmlr
Copy link
Member

krlmlr commented Jul 21, 2020

Please install the latest tibble version from CRAN.

Nelson-Gon added a commit to Nelson-Gon/mde that referenced this issue Aug 15, 2020
@AmitLevinson
Copy link

AmitLevinson commented Aug 23, 2020

Also came across this issue and found this previous discussion helpful to fix the problem. It was basically resolved when I properly updated {tibble}:

rstats-wtf/what-they-forgot#62 (comment)

@yutthi
Copy link

yutthi commented Sep 23, 2020

Probably it can be fixed by using as.data.frame() after using group_by() and slice
like x <- as.data.frame(x)

krlmlr added a commit that referenced this issue Feb 25, 2021
tibble 3.0.3

- Fix test compatibility with rlang 0.4.7.

- Fix warning about `needs_dots` arguments with pillar >= 1.4.5 (#798).
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants