Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing as_tibble() error message for tables without dimnames() #839

Closed
allenbaron opened this issue Jan 21, 2021 · 2 comments · Fixed by #854
Closed

Consider changing as_tibble() error message for tables without dimnames() #839

allenbaron opened this issue Jan 21, 2021 · 2 comments · Fixed by #854

Comments

@allenbaron
Copy link

This is a follow-up to issue #712.

Would you consider changing the error message to recommend using the .name_repair argument of as_tibble() instead of names(dimnames(x)) <- ...? It's easier to implement in a pipe and names could be set afterward with set_names().
@krlmlr krlmlr mentioned this issue Feb 14, 2021
Merged
@krlmlr
Copy link
Member

krlmlr commented Feb 14, 2021

Thanks, good idea!

krlmlr added a commit that referenced this issue Feb 14, 2021
@krlmlr
Merge pull request #854 from tidyverse/f-839-name-repair-message
3045222 
- `as_tibble.table()` mentions `.name_repair` argument in the error message (#839).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention .name_repair in error message for as_tibble.table() tidyverse/tibble
2 participants
@krlmlr @allenbaron