Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on named input for tribble() #871

Closed
lorenzwalthert opened this issue Mar 31, 2021 · 3 comments · Fixed by #874
Closed

Error on named input for tribble() #871

lorenzwalthert opened this issue Mar 31, 2021 · 3 comments · Fixed by #874
Labels
help wanted ❤️ we'd love your help!

Comments

@lorenzwalthert
Copy link
Contributor

In a huge tribble, I inserted named objects and got no error, and it took forever to realise I must use , instead of = as a separator.

tibble::tribble(
  ~x, ~y,
  # ... old code I had already
  "a", "b",

  # I inserted this
  "c" = "yy",
  "y" = '4'

  # other code
  # ...
)
#> # A tibble: 2 x 2
#>   x     y    
#>   <chr> <chr>
#> 1 a     b    
#> 2 yy    4

Created on 2021-03-31 by the reprex package (v1.0.0)

I suggest to error if any element is named.

@krlmlr
Copy link
Member

krlmlr commented Mar 31, 2021

Good idea. Would you like to pr?

@krlmlr krlmlr added the help wanted ❤️ we'd love your help! label Apr 16, 2021
@krlmlr krlmlr pinned this issue Apr 16, 2021
@lorenzwalthert
Copy link
Contributor Author

Yes.

krlmlr added a commit that referenced this issue Apr 16, 2021
- `tribble()` and `frame_matrix()` give an error if values are named (#871, @lorenzwalthert).
@krlmlr krlmlr unpinned this issue Jun 9, 2021
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted ❤️ we'd love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants