Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recycling RHS in subassignment too early #922

Closed
krlmlr opened this issue Jul 30, 2021 · 1 comment · Fixed by #947
Closed

Avoid recycling RHS in subassignment too early #922

krlmlr opened this issue Jul 30, 2021 · 1 comment · Fixed by #947

Comments

@krlmlr
Copy link
Member

krlmlr commented Jul 30, 2021

Recycling should be implicit by vctrs, for performance and cache locality.

@krlmlr krlmlr added this to the 3.1.4 milestone Jul 30, 2021
krlmlr added a commit that referenced this issue Aug 7, 2021
- `x[i, j] <- one_row_value` avoids explicit recycling of the right-hand side, the recycling happens implicitly in `vctrs::vec_assign()` for performance (#922).
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant