More thoughts on print method

[hadley]

While I like the <> in the column descs, I don't like it so much in the overall object description - I think it's a bit distracting.

So how about instead of:

<tibble [32 x 11]>
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1

We have something like this:

# A tibble with 32 rows and 11 columns
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1

Where "A tibble with ..." is generated by a new obj_desc() generic which would return a character vector giving a (potentially) multiple line textual description. print.tbl_df would add the # (and enough spaces to make it line up with the row numbers) and the new lines.

[krlmlr]

I actually liked the # A 32 x 11 tibble variant -- did you mean to remove that comment?

[hadley]

Hmmm, I thought it looked ok, but maybe it seems ok now. Here it is again a long with another variant:

# A 32 x 11 tibble
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1

# A tibble: 32 x 11
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1

[dracodoc]

How about this:
Row description is close to last row, column description is close to columns. Not printed rows or columns are marked with ...

                                          [11 in 11 columns printed]
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb 
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> 
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1
[3 in 3 rows printed]

                                         [ 11 in 11 columns printed]
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb 
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> 
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1     4     4
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1     4     4
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1     4     1
...
[3 in 32 rows printed]

                               [9 in 11 columns printed] ..
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am ..
*  <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> ..
1   21.0     6 160.0   110  3.90 2.620 16.46     0     1 ..
2   21.0     6 160.0   110  3.90 2.875 17.02     0     1 ..
3   22.8     4 108.0    93  3.85 2.320 18.61     1     1 ..
...
[3 in 32 rows printed]

There could also be an option(global option?) to show names of columns that not printed.

[krlmlr]

Just merged an implementation, please comment/reopen/open a new issue in case of any problems.

[krlmlr]

@dracodoc: Columns that would make the output too wide are already printed, see the n_extra argument. I don't really like splitting number of rows and columns like in your example, in particular because other information (think SQL sources or grouped data frames) also needs to be printed. Nevertheless I appreciate your input.

[dracodoc]

No problem, I just felt it's natural to put row number after the last row. Of course you need to consider all cases and get a balance.