use_as_rownames function #8

[zhilongjia]

use_as_rownames function returns data.frame, not tbl, with rownames. This is to solve issue #8.

Closes #8.

Closes #28.

[krlmlr]

I'd prefer if the two functions were documented together (via @rdname).

[codecov-io]

Current coverage is 96.57%

Merging #11 into master will increase coverage by +0.13% as of f2e0c32

@@            master     #11   diff @@
======================================
  Files           11      11       
  Stmts          422     438    +16
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            407     423    +16
  Partial          0       0       
  Missed          15      15       

Review entire Coverage Diff as of f2e0c32

Powered by Codecov. Updated on successful CI builds.

[krlmlr]

If this is intended behavior, it should be documented, but I wonder if it's necessary. (One can always write use_as_rownames() %>% as.data.frame or the other way round, if necessary.)

[zhilongjia]

At least to me, use_as_rownames is to interact with the base::data.frame and tbl is trying to avoid rownames. So I convert it into data.frame directly. Comments?

[krlmlr]

Makes sense; still, needs to be documented.

[zhilongjia]

I do not get meaning of to be documented. Return a data.frame is documented in details now. Correct?

[krlmlr]

Missed that, sorry.

[zhilongjia]

add_rownames keeps row names of data frame (Probably it affects a lots). And it will stop if there is a var column names in the input data frame.

More tests are added (I use test a few. Maybe need update).

use_as_rownames will update the row names using var whether it exists or not，then delete the var column. And it returns data.frame so far.

[krlmlr]

This should go into the @details section

[krlmlr]

Thanks. This looks good, I'll merge it soon.

[krlmlr]

This spurious change prevents me from merging into master.

[krlmlr]

The new function isn't supposed to convert to tbl_df. Let's remove add_rownames() altogether and keep it only in dplyr for compatibility.

[zhilongjia]

rownames_to_column is a copy of add_rownames. So you mean keep the input of rownames_to_column as it is (I did not change that section)? For example, input data.frame output data.frame? I will remove add_rownames.

[krlmlr]

Yes, data.frame -> data.frame, tbl_df -> tbl_df. Thanks.