chore: Pass error call to vec_as_location()
#1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1065.
This is just a POC for how to better support error calls in tibble. In this case I'm just passing the relevant
call = caller_env()
down to vctrs functions. You can also pass it toabort()
, or you can assigncnd$call <- <caller_env>
before callingcnd_signal()
.Note that input checking functions that check a particular argument should also pass
arg
toabort()
. The last version of rlang now highlights the corresponding argument in the backtrace. The function call is also highlighted, provided a frame environment was supplied as call.