Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add frame matrix #168
I extract the code that parses tribble(...) arguments into
If this strategy / function names seem okay, I'll submit more PR for edge cases.
Current coverage is 99.47% (diff: 97.67%)
@@ master #168 diff @@ ========================================== Files 16 16 Lines 740 757 +17 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 737 753 +16 - Misses 3 4 +1 Partials 0 0
Thanks! Looks good so far, I'd prefer if the code was split in even smaller functions.
Did you write some code for this yourselves? I pull rebase from master and saw some new code for edge cases. Just curious.
I think I've addressed all of your comments in the last PR (thanks as always!). Is there anything more I need to do to get Github's new "Requested changes" to go away?
@krlmlr I add a PR for the smaller stuff.
If I extract out the code after
Thanks, almost good to merge. Could you please fix, and also reorder the new functions:
- tribble(), its alias, and frame_matrix()
- extract_frame_data_from_dots() and its callees
- turn_frame_data_into_tibble() and callees
- turn_frame_data_into_matrix() and callees
@krlmlr I moved things around as requested -- thanks for being patient with your guidance.
Two more things we may want to do