New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive classes and names from `x` not `df` #186

Merged
merged 3 commits into from Jan 4, 2017

Conversation

Projects
None yet
3 participants
@holstius
Contributor

holstius commented Oct 31, 2016

In glimpse.tbl, use of as.data.frame may drop classes from x when creating df. See #185
for reprex.

Fixes #185.

Derive classes and names from `x` not `df`
`as.data.frame` may drop classes from `x` when creating `df`. See #185
for reprex.
@codecov-io

This comment has been minimized.

codecov-io commented Oct 31, 2016

Current coverage is 99.59% (diff: 100%)

Merging #186 into master will increase coverage by <.01%

@@             master       #186   diff @@
==========================================
  Files            16         16          
  Lines           738        740     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            735        737     +2   
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 7c4a712...bf8230c

@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 17, 2016

Thanks. This looks good, would you mind adding a test (perhaps based on your reprex)?

holstius added some commits Nov 28, 2016

Assign type_sum.SomeClass to .GlobalEnv (temporarily)
Simply defining type_sum.SomeClass inside a test_that block doesn't
seem to work.

So, let's assign it to .GlobalEnv and then politely destroy it when
we're done testing.
@holstius

This comment has been minimized.

Contributor

holstius commented Nov 28, 2016

Creating a type_sum.SomeClass that glimpse will actually find (during the test) was trickier than I thought. What I did is probably not ideal. If you know where best to put type_sum.SomeClass (that is, in what environment), I'm all ears!

@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 28, 2016

I had solved a similar problem in helper-unknown-rows.R .

@krlmlr krlmlr modified the milestone: 1.3.0 Jan 4, 2017

@krlmlr krlmlr merged commit bf8230c into tidyverse:master Jan 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

krlmlr added a commit that referenced this pull request Jan 4, 2017

Merge branch 'b-#185-glimpse-type_sum'. Closes #186.
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 4, 2017

Thanks!

krlmlr added a commit that referenced this pull request Jan 4, 2017

Merge tag 'v1.2-14'
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
- Reword documentation for `tribble()` (#191, @kwstat).
- Unicode multiplication sign is rendered as `x` if it cannot be represented in the current locale (#192, @ncarchedi).

krlmlr added a commit that referenced this pull request Apr 1, 2017

Merge tag 'v1.3.0'
Bug fixes
=========

- Time series matrices (objects of class `mts` and `ts`) are now supported in `as_tibble()` (#184).
- The `all_equal()` function (called by `all.equal.tbl_df()`) now forwards to `dplyr` and fails with a helpful message if not installed. Data frames with list columns cannot be compared anymore, and differences in the declared class (`data.frame` vs. `tbl_df`) are ignored. The `all.equal.tbl_df()` method gives a warning and forwards to `NextMethod()` if `dplyr` is not installed; call `all.equal(as.data.frame(...), ...)` to avoid the warning. This ensures consistent behavior of this function, regardless if `dplyr` is loaded or not (#198).

Interface changes
=================

- Now requiring R 3.1.0 instead of R 3.1.3 (#189).
- Add `as.tibble()` as an alias to `as_tibble()` (#160, @LaDilettante).
- New `frame_matrix()`, similar to `frame_data()` but for matrices (#140, #168, @LaDilettante).
- New `deframe()` as reverse operation to `enframe()` (#146, #214).
- Removed unused dependency on `assertthat`.

Features
========

General
-------

- Keep column classes when adding row to empty tibble (#171, #177, @LaDilettante).
- Singular and plural variants for error messages that mention a list of objects (#116, #138, @LaDilettante).
- `add_column()` can add columns of length 1 (#162, #164, @LaDilettante).

Input validation
----------------

- An attempt to read or update a missing column now throws a clearer warning (#199).
- An attempt to call `add_row()` for a grouped data frame results in a helpful error message (#179).

Printing
--------

- Render Unicode multiplication sign as `x` if it cannot be represented in the current locale (#192, @ncarchedi).
- Backtick `NA` names in printing (#206, #207, @jennybc).
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
- The `max.print` option is ignored when printing a tibble (#194, #195, @t-kalinowski).

Documentation
=============

- Fix typo in `obj_sum` documentation (#193, @etiennebr).
- Reword documentation for `tribble()` (#191, @kwstat).
- Now explicitly stating minimum Rcpp version 0.12.3.

Internal
========

- Using registration of native routines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment