New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the definition of tribble. #191

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kwstat
Contributor

kwstat commented Nov 10, 2016

I was slightly confused by the original wording. This attempts to improve.

Clarify the definition of tribble.
I was slightly confused by the original wording.  This attempts to improve.
@codecov-io

This comment has been minimized.

codecov-io commented Nov 10, 2016

Current coverage is 99.59% (diff: 100%)

Merging #191 into master will not change coverage

@@             master       #191   diff @@
==========================================
  Files            16         16          
  Lines           738        738          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            735        735          
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 7c4a712...41975f9

#' in columns. This is useful for small tables of data where readability is
#' important. Please see \link{tibble-package} for a general introduction.
#' Create \code{\link{tibble}}s by inputing the data observations row-by-row,
#' rather than column-by-column. This is useful for small tables of data

This comment has been minimized.

@krlmlr

krlmlr Nov 11, 2016

Member

How about keeping the first sentence as-is, and adding a second sentence that explains slightly differently? We could also expand the examples, so that the intention of tribble() is clearer.

This comment has been minimized.

@kwstat

kwstat Feb 16, 2017

Contributor

I think it could help to combine tribble.Rd and tibble.Rd into one file, so that the difference between the two methods of input can be seen on the same page.

@krlmlr krlmlr modified the milestone: 1.3.0 Jan 4, 2017

@krlmlr krlmlr closed this in de1c4c5 Jan 4, 2017

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 4, 2017

Thanks. How does the new wording look to you?

krlmlr added a commit that referenced this pull request Jan 4, 2017

Merge tag 'v1.2-14'
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
- Reword documentation for `tribble()` (#191, @kwstat).
- Unicode multiplication sign is rendered as `x` if it cannot be represented in the current locale (#192, @ncarchedi).

krlmlr added a commit that referenced this pull request Apr 1, 2017

Merge tag 'v1.3.0'
Bug fixes
=========

- Time series matrices (objects of class `mts` and `ts`) are now supported in `as_tibble()` (#184).
- The `all_equal()` function (called by `all.equal.tbl_df()`) now forwards to `dplyr` and fails with a helpful message if not installed. Data frames with list columns cannot be compared anymore, and differences in the declared class (`data.frame` vs. `tbl_df`) are ignored. The `all.equal.tbl_df()` method gives a warning and forwards to `NextMethod()` if `dplyr` is not installed; call `all.equal(as.data.frame(...), ...)` to avoid the warning. This ensures consistent behavior of this function, regardless if `dplyr` is loaded or not (#198).

Interface changes
=================

- Now requiring R 3.1.0 instead of R 3.1.3 (#189).
- Add `as.tibble()` as an alias to `as_tibble()` (#160, @LaDilettante).
- New `frame_matrix()`, similar to `frame_data()` but for matrices (#140, #168, @LaDilettante).
- New `deframe()` as reverse operation to `enframe()` (#146, #214).
- Removed unused dependency on `assertthat`.

Features
========

General
-------

- Keep column classes when adding row to empty tibble (#171, #177, @LaDilettante).
- Singular and plural variants for error messages that mention a list of objects (#116, #138, @LaDilettante).
- `add_column()` can add columns of length 1 (#162, #164, @LaDilettante).

Input validation
----------------

- An attempt to read or update a missing column now throws a clearer warning (#199).
- An attempt to call `add_row()` for a grouped data frame results in a helpful error message (#179).

Printing
--------

- Render Unicode multiplication sign as `x` if it cannot be represented in the current locale (#192, @ncarchedi).
- Backtick `NA` names in printing (#206, #207, @jennybc).
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
- The `max.print` option is ignored when printing a tibble (#194, #195, @t-kalinowski).

Documentation
=============

- Fix typo in `obj_sum` documentation (#193, @etiennebr).
- Reword documentation for `tribble()` (#191, @kwstat).
- Now explicitly stating minimum Rcpp version 0.12.3.

Internal
========

- Using registration of native routines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment