Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deframe() #214

merged 3 commits into from Feb 7, 2017

deframe() #214

merged 3 commits into from Feb 7, 2017


Copy link

@krlmlr krlmlr commented Jan 16, 2017

Fixes #146.

Copy link

@codecov-io codecov-io commented Jan 16, 2017

Current coverage is 99.31% (diff: 100%)

Merging #214 into master will increase coverage by <.01%

@@             master       #214   diff @@
  Files            16         16          
  Lines           721        725     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
+ Hits            716        720     +4   
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last update 3d6f8b4...7ca3c24

@krlmlr krlmlr merged commit 00ec00c into master Feb 7, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@krlmlr krlmlr deleted the f-#146-deframe branch Feb 7, 2017
@@ -1,10 +1,10 @@
#' Converting atomic vectors to data frames
#' Converting atomic vectors to data frames, and vice versa

This comment has been minimized.


jennybc Feb 7, 2017

Excitement about deframe() brought my eyeballs here.

enframe() works for lists. Should the "atomic" qualification be dropped or is that an undocumented feature you are not ready to explicitly support?

This comment has been minimized.


krlmlr Feb 7, 2017
Author Member

I'm happy to explicitly support lists. Would you like to submit a PR?

This comment has been minimized.


jennybc Feb 7, 2017

I'm guessing that will involve more than changing this documentation 😬? Suspect this merits a bit of discussion ... shall I open an issue for it?

krlmlr added a commit that referenced this pull request Apr 1, 2017
Bug fixes

- Time series matrices (objects of class `mts` and `ts`) are now supported in `as_tibble()` (#184).
- The `all_equal()` function (called by `all.equal.tbl_df()`) now forwards to `dplyr` and fails with a helpful message if not installed. Data frames with list columns cannot be compared anymore, and differences in the declared class (`data.frame` vs. `tbl_df`) are ignored. The `all.equal.tbl_df()` method gives a warning and forwards to `NextMethod()` if `dplyr` is not installed; call `all.equal(, ...)` to avoid the warning. This ensures consistent behavior of this function, regardless if `dplyr` is loaded or not (#198).

Interface changes

- Now requiring R 3.1.0 instead of R 3.1.3 (#189).
- Add `as.tibble()` as an alias to `as_tibble()` (#160, @LaDilettante).
- New `frame_matrix()`, similar to `frame_data()` but for matrices (#140, #168, @LaDilettante).
- New `deframe()` as reverse operation to `enframe()` (#146, #214).
- Removed unused dependency on `assertthat`.



- Keep column classes when adding row to empty tibble (#171, #177, @LaDilettante).
- Singular and plural variants for error messages that mention a list of objects (#116, #138, @LaDilettante).
- `add_column()` can add columns of length 1 (#162, #164, @LaDilettante).

Input validation

- An attempt to read or update a missing column now throws a clearer warning (#199).
- An attempt to call `add_row()` for a grouped data frame results in a helpful error message (#179).


- Render Unicode multiplication sign as `x` if it cannot be represented in the current locale (#192, @ncarchedi).
- Backtick `NA` names in printing (#206, #207, @jennybc).
- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).
- The `max.print` option is ignored when printing a tibble (#194, #195, @t-kalinowski).


- Fix typo in `obj_sum` documentation (#193, @etiennebr).
- Reword documentation for `tribble()` (#191, @kwstat).
- Now explicitly stating minimum Rcpp version 0.12.3.


- Using registration of native routines.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants