Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft for decorations #411

Open
wants to merge 2 commits into
base: master
from

Conversation

@krlmlr
Copy link
Member

commented May 23, 2018

@kovla

This comment has been minimized.

Copy link

commented May 23, 2018

Looks like a very elegant solution. I assume that the decorations do not change the underlying data in any way, just add attributes?

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

Yes, it's just a new class and custom attributes.

@krlmlr krlmlr requested a review from hadley May 23, 2018

@krlmlr krlmlr referenced this pull request May 24, 2018

Closed

Idea on datetimes/timezones #25

@hadley

This comment has been minimized.

Copy link
Member

commented Jun 27, 2018

I think decor() should live in pilar, and decor_chr() and decor_num() in tibble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.