Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dplyr in tests if unavailable. #420

Merged
merged 1 commit into from Jun 12, 2018
Merged

Conversation

@QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jun 10, 2018

Since dplyr imports tibble, requiring dplyr would be a dependency loop. This breaks the loop and keeps dplyr working as a suggestion.

@krlmlr krlmlr merged commit 89aa5cf into tidyverse:master Jun 12, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 12, 2018

Thanks!

@QuLogic QuLogic deleted the QuLogic:skip-dplyr branch Jun 12, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants