Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exportClass(tbl_df) to NAMESPACE #436

Merged
merged 3 commits into from Jul 29, 2018
Merged

Conversation

@jeffreyhanson
Copy link
Contributor

@jeffreyhanson jeffreyhanson commented Jul 24, 2018

This PR adds roxygen2 commands to add exportClass(tbl_df) to the _NAMESPACE (see tbl_df.r) and an updated NAMESPACE file. Since I ran devtools::document() to update the package's NAMESPACE, it appears that several other files got updated in the process. I figured you might want to have these files in synch with the roxygen2 code - but let me know if I should resubmit this PR with just the tbl_df.r and NAMESPACE files updated. For more information on this PR, please see #434.

@jeffreyhanson
Copy link
Contributor Author

@jeffreyhanson jeffreyhanson commented Jul 24, 2018

Sorry, I forgot to document the S4 class so now the checks are failing. I'll sort this out in a minute.

@codecov
Copy link

@codecov codecov bot commented Jul 24, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          25       25           
  Lines        1048     1048           
=======================================
  Hits          952      952           
  Misses         96       96
Impacted Files Coverage Δ
R/tibble.R 96.42% <ø> (ø) ⬆️
R/tbl-df.r 98.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29b5b7...cb6d40e. Read the comment docs.

@krlmlr krlmlr merged commit d5dd518 into tidyverse:master Jul 29, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch Coverage not affected when comparing a29b5b7...cb6d40e
Details
@codecov
codecov/project 90.83% remains the same compared to a29b5b7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 29, 2018

Thanks! I keep forgetting updating the API file.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants