New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples with suggested packages #453

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@Enchufa2
Copy link
Contributor

Enchufa2 commented Aug 13, 2018

A stop call after requireNamespace causes R CMD check to fail if the suggested package nycflights13 is not installed.

@krlmlr krlmlr merged commit d2f90db into tidyverse:master Aug 13, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Aug 13, 2018

Thanks!

@Enchufa2 Enchufa2 deleted the Enchufa2:nycflights branch Aug 13, 2018

@Enchufa2

This comment has been minimized.

Copy link
Contributor

Enchufa2 commented Aug 13, 2018

Note: I didn't re-roxygenise the package.

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Aug 13, 2018

Thanks for the heads-up, I'll do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment