Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use the created (or passed) title argument rather than string … #610

Merged
merged 3 commits into from Jul 1, 2019

Conversation

xvrdm
Copy link

@xvrdm xvrdm commented Jun 19, 2019

One of my students just showed me that they could not use the little clipboard button in the viewer because the name of the object was always changed to "title", which is a departure from utils::View().

Not sure if current fixed "title" is desired. Removing the quotes "seems" to fix the problem. Unfortunately I have no idea on how to test this (I could not find related tests in the repo).

krlmlr
krlmlr approved these changes Jun 19, 2019
Copy link
Member

@krlmlr krlmlr left a comment

Good catch! This looks like a premature commit/merge. I believe we need to splice also the title into the call to avoid weird effects. Can you please double-check?

R/view.R Outdated Show resolved Hide resolved
@krlmlr krlmlr merged commit f0d0106 into tidyverse:master Jul 1, 2019
2 of 4 checks passed
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 1, 2019

Thanks! I'm still wondering why we don't seem to need the quo() anymore ;-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants