Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots to align with dev rlang #908

Merged
merged 6 commits into from Jul 21, 2021
Merged

Update snapshots to align with dev rlang #908

merged 6 commits into from Jul 21, 2021

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 21, 2021

Are these changes intended?

@krlmlr krlmlr requested a review from lionel- July 21, 2021 03:52
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be supplying a named vector of bullets with empty "" names? We now require explicit "*" bullets to align with cli and there's backward-compatibility behaviour for the case of NULL names but not for the case of all "" names.

To make this easier, set_names() is now vectorised so you can do set_names(bullets, "*").

@krlmlr
Copy link
Member Author

krlmlr commented Jul 21, 2021

Thanks. I'm having trouble to find a clean upgrade path, because rlang 0.4.11 forbids explicit "*" in the bullets.

@krlmlr
Copy link
Member Author

krlmlr commented Jul 21, 2021

I'm going to use i instead of * for now where appropriate.

@krlmlr krlmlr merged commit 832285c into master Jul 21, 2021
@krlmlr krlmlr deleted the f-dev-rlang branch July 21, 2021 11:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants