Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chop() should require cols #1205

Closed
DavisVaughan opened this issue Nov 9, 2021 · 0 comments · Fixed by #1207
Closed

chop() should require cols #1205

DavisVaughan opened this issue Nov 9, 2021 · 0 comments · Fixed by #1207
Labels
bug an unexpected problem or unintended behavior nesting 🐦 nesting, chopping, and packing

Comments

@DavisVaughan
Copy link
Member

I don't think this should be optional

tidyr/R/chop.R

Lines 70 to 72 in e7aac41

if (missing(cols)) {
return(data)
}

@DavisVaughan DavisVaughan added bug an unexpected problem or unintended behavior nesting 🐦 nesting, chopping, and packing labels Nov 9, 2021
@DavisVaughan DavisVaughan mentioned this issue Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior nesting 🐦 nesting, chopping, and packing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update and simplify chop() implementation DavisVaughan/tidyr
1 participant
@DavisVaughan