Remove temporary backwards compat support for list()
in names_ptypes
and values_ptypes
of pivot_longer()
#1296
Closed
4 tasks done
Labels
See #1291 for even more details.
When we moved from default values of
names/values_ptypes = list()
tonames/values_ptypes = NULL
and allowednames_ptypes = list()
to mean "use a list ptype for all columns", this caused breakage in extension packages that extendedpivot_longer()
and still hadlist()
as their default value for these arguments.So we temporarily special cased a value of
list()
for these two arguments to be identical toNULL
to give the extension packages time to update to the new default. Documentation was updated to mention this special casing, and to state that it was temporary.We'd like to remove this special casing once the packages are updated so that
names_ptypes = list()
will again mean "use a list ptype for all columns".This issue tracks the status of the known packages that have this issue. Once they are all fixed, we can remove the special casing from the code and documentation:
pivot_longer()
args taking single/multiple values dbplyr#744pivot_longer()
signature r-spatial/sf#1895pivot_longer()
argument defaults fromlist()
toNULL
sparklyr/sparklyr#3221pivot_longer()
argument defaults fromlist()
toNULL
stemangiola/tidyseurat#49Once these issues are all resolved, revert everything done in this PR #1297
The text was updated successfully, but these errors were encountered: