Skip to content

Remove temporary backwards compat support for list() in names_ptypes and values_ptypes of pivot_longer() #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
DavisVaughan opened this issue Dec 21, 2021 · 3 comments · Fixed by #1434
Closed
4 tasks done
Labels
feature a feature request or enhancement pivoting ♻️ pivot rectangular data to different "shapes"

Comments

@DavisVaughan
Copy link
Member

DavisVaughan commented Dec 21, 2021

See #1291 for even more details.

When we moved from default values of names/values_ptypes = list() to names/values_ptypes = NULL and allowed names_ptypes = list() to mean "use a list ptype for all columns", this caused breakage in extension packages that extended pivot_longer() and still had list() as their default value for these arguments.

So we temporarily special cased a value of list() for these two arguments to be identical to NULL to give the extension packages time to update to the new default. Documentation was updated to mention this special casing, and to state that it was temporary.

We'd like to remove this special casing once the packages are updated so that names_ptypes = list() will again mean "use a list ptype for all columns".

This issue tracks the status of the known packages that have this issue. Once they are all fixed, we can remove the special casing from the code and documentation:

Once these issues are all resolved, revert everything done in this PR #1297

@DavisVaughan DavisVaughan added feature a feature request or enhancement pivoting ♻️ pivot rectangular data to different "shapes" labels Dec 21, 2021
@mgirlich

This comment has been minimized.

@DavisVaughan

This comment has been minimized.

@DavisVaughan
Copy link
Member Author

It looks like all 4 of the packages here have been updated on CRAN, so I think we can move on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement pivoting ♻️ pivot rectangular data to different "shapes"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants