Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which functions work with grouped data #952

Closed
gregorp opened this issue May 4, 2020 · 1 comment · Fixed by #1438
Closed

Document which functions work with grouped data #952

gregorp opened this issue May 4, 2020 · 1 comment · Fixed by #1438
Milestone

Comments

@gregorp
Copy link

gregorp commented May 4, 2020

On the ?fill help page, there is no statement that fill knows to respect groups from dplyr::group_by. (The last example does demonstrate this.) Same on the ?expand and ?complete help pages, possibly other functions too. It would be great if there was a standard sentence or phrase that was part of the Description section for all non-dplyr functions that know what to do with a grouped_df. Perhaps "Respects tibble groupings".

I think this would both serve as a good reference (I constructed a little example before posting thing to check on expand... I was pretty sure it respected groups but needed to check to see), and also for those new users who read help pages it might help cement the concept that group_by isn't magic that works with every function, only specially constructed functions.

@DavisVaughan
Copy link
Member

#1300 mentions in the docs that complete() and expand() work with grouped data frames, and adds examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants